Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates and reorganizes the test data and associated metadata files for the ACS 5-year subject table S0902. It replaces older test data with a new summary file, suggesting an update to the data being tested, and standardizes the naming and internal structure of the associated mapping files for improved consistency. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates test files for the S0902 subject table, replacing data from 2018/2019 with data from 2012 and renaming some files for consistency. However, the PR title "Adding latest files" is misleading given the data is older. More importantly, the removal of S0902_state_county_places_cleaned.csv will likely break the tests in subject_table_test.py, which expects a *cleaned.csv file. Please address the broken test. For future PRs, please use a more descriptive title and provide a summary of changes in the description.
| @@ -1,217 +0,0 @@ | |||
| Year,Place,StatVar,Quantity | |||
There was a problem hiding this comment.
The test script scripts/us_census/acs5yr/subject_tables/subject_table_test.py requires a *cleaned.csv file in the testdata directory for each subject table test. By removing this file without providing a replacement for the 2012 data, the tests for S0902 will fail. Please add the corresponding cleaned.csv file for the new test data.
| "total StatVarObservations": 3774 | ||
| }, | ||
| "2012": { | ||
| "filename": "S0902/ACSST5Y2012.S0902_data_with_overlays_1111-11-11T111111.csv", |
There was a problem hiding this comment.
The filename value S0902/ACSST5Y2012.S0902_data_with_overlays_1111-11-11T111111.csv includes a placeholder timestamp 1111-11-11T111111. While this is likely for test determinism, it's an unusual value that could be confusing. Consider using a more descriptive placeholder or adding a comment in the test setup explaining its purpose.
| { | ||
| "summary": { | ||
| "column map generator commit SHA": "", | ||
| "data processing script commit SHA": "", | ||
| "total StatVarObservations": 3774 | ||
| }, | ||
| "2012": { | ||
| "filename": "S0902/ACSST5Y2012.S0902_data_with_overlays_1111-11-11T111111.csv", | ||
| "number of columns in dataset": 146, | ||
| "number of rows in dataset": 998, | ||
| "number of statVars generated for columns": 108, | ||
| "number of observations": 3774, | ||
| "number of unique StatVars with observations": 108, | ||
| "number of unique geos": 35, | ||
| "number of StatVars in mcf_dict": 108 | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
This file is missing a final newline character. It's a common convention to end text files with a newline. This helps prevent issues with file processing and tools like cat.
| { | |
| "summary": { | |
| "column map generator commit SHA": "", | |
| "data processing script commit SHA": "", | |
| "total StatVarObservations": 3774 | |
| }, | |
| "2012": { | |
| "filename": "S0902/ACSST5Y2012.S0902_data_with_overlays_1111-11-11T111111.csv", | |
| "number of columns in dataset": 146, | |
| "number of rows in dataset": 998, | |
| "number of statVars generated for columns": 108, | |
| "number of observations": 3774, | |
| "number of unique StatVars with observations": 108, | |
| "number of unique geos": 35, | |
| "number of StatVars in mcf_dict": 108 | |
| } | |
| } | |
| { | |
| "summary": { | |
| "column map generator commit SHA": "", | |
| "data processing script commit SHA": "", | |
| "total StatVarObservations": 3774 | |
| }, | |
| "2012": { | |
| "filename": "S0902/ACSST5Y2012.S0902_data_with_overlays_1111-11-11T111111.csv", | |
| "number of columns in dataset": 146, | |
| "number of rows in dataset": 998, | |
| "number of statVars generated for columns": 108, | |
| "number of observations": 3774, | |
| "number of unique StatVars with observations": 108, | |
| "number of unique geos": 35, | |
| "number of StatVars in mcf_dict": 108 | |
| } | |
| } | |
1 participant
No description provided.